This repository has been archived by the owner on Oct 12, 2021. It is now read-only.
Bug 393073 - NPE in the hasNext method #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current status is that the empty nextPage property: <oslc:nextPage rdf:resource="" /> Causes Jena to deserialise a full triple statement with a non-empty Object: subject = "http://example.com/provider/query?oslc.where=ex%3Aproduct%3D%22Product%20A%2" predicate = "http://open-services.net/ns/core#nextPage" object = "http://example.com/provider/query" Change-Id: I8c1088ebc7101165834fe0a0a4a870e600020812 Signed-off-by: Andrew Berezovskyi <[email protected]>
|
Issue tracker reference: |
|
@jamsden I will let you handle this client PR |
|
If you need my help, I can try updating the PR. |
berezovskyi
added
Status: Changes Requested
Priority: Low
and removed
Status: Review Needed
Priority: Medium
labels
jamsden
reviewed
Feb 15, 2019
|
Yes, here is the test: https://github.com/eclipse/lyo.client/pull/5/files#diff-0865771cb59c619976d66fa48ba77727R75 |
Change-Id: I29204f5a77074f1c547eb350427435adba9bdcd1
berezovskyi
changed the title
berezovskyi
added
Status: Review Needed
Xtra: Fix Verified
and removed
Status: Changes Requested
labels
Change-Id: I614efb392be24a435aad8ec1ab3743ba3bc10ed9 Signed-off-by: Andrew Berezovskyi <[email protected]>
|
There is a hiccup with re-running the tests. Seems like newer Jena versions have become more strict regarding the URIs, the test fails because of an unencoded space character. Will notify you once it's fixed.
…--
/Andrew
15 feb. 2019 kl. 22:10 skrev Jim Amsden <[email protected]<mailto:[email protected]>>:
@jamsden commented on this pull request.
As far as I can see, this looks ok. Have the test been run and demonstrated correct results?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<#5 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAD83nN4QKjArOxPpV_PbGB_cKMIxBkKks5vNyJKgaJpZM4UFN8X>.
|
Change-Id: I95f6fb002de836f091483dcc7f5a6f6d99623e40 Signed-off-by: Andrew Berezovskyi <[email protected]>
|
Strange! Now the test that used to pass a year ago does not pass... This gets recognised as a triple Hmm... according to https://www.w3.org/TR/rdf-syntax-grammar/#section-baseURIs
|
Change-Id: I019092e760ae6a8337fb16b3b9e117810f0e3139 Signed-off-by: Andrew Berezovskyi <[email protected]>
|
@jamsden I think d2026d9#diff-5776f1d67363c3a733d3c944bd2f24f3R146 fix is even better to protect against NPEs. Ready for review/merge. |
Closed
berezovskyi
commented
Feb 16, 2019
| } | ||
|
|
||
| private OslcQueryResult(OslcQueryResult prev) { | ||
| this.query = new OslcQuery(prev); | ||
| this.query = prev.query; |
There was a problem hiding this comment.
need to check for possible regression
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current status is that the empty nextPage property:
<oslc:nextPage rdf:resource="" />
Causes Jena to deserialise a full triple statement with a non-empty
Object:
subject = "http://example.com/provider/query?oslc.where=ex%3Aproduct%3D%22Product%20A%2"
predicate = "http://open-services.net/ns/core#nextPage"
object = "http://example.com/provider/query"