Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect initServerProviders() method #275

Merged
merged 2 commits into from
Dec 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
- Using depedency injection for Manager, Store and TRS classes
- Provide flexibility to for Store properties to be set via the Environment.
- Changing the way Resource and ResourceProperty items are represented in dialogs. We include prefixes to make their identification easier.
- Protect initServerProviders() method

### Deprecated

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,11 +166,8 @@ public class [javaClassNameForSingleton(aServiceProviderCatalog) /]

public static ServiceProvider [ '[' ']' /] getServiceProviders(HttpServletRequest httpServletRequest)
{
synchronized(serviceProviders)
{
initServiceProviders(httpServletRequest);
return serviceProviders.values().toArray(new ServiceProvider[ '[' /] serviceProviders.size()[ ']' /]);
}
initServiceProviders(httpServletRequest);
return serviceProviders.values().toArray(new ServiceProvider[ '[' /] serviceProviders.size()[ ']' /]);
}

public static boolean containsServiceProvider(final String identifier) {
Expand Down Expand Up @@ -279,7 +276,7 @@ public class [javaClassNameForSingleton(aServiceProviderCatalog) /]
* creation to create unique URI paths for each ServiceProvider.
*
*/
protected static void initServiceProviders (HttpServletRequest httpServletRequest)
protected static synchronized void initServiceProviders (HttpServletRequest httpServletRequest)
{
try {
// [protected ('initServiceProviders')]
Expand Down
Loading