Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle relative paths in JavaProjectConfigurator.getFolder and simplify #1694

Merged

Conversation

HannesWell
Copy link
Contributor

The TychoLifecycleMapping.EclipsePluginProjectConfigurator can call getFolder() with a relative path which only seems to cause trouble on Windows.

Copy link

github-actions bot commented Feb 19, 2024

Test Results

  214 files  ±0    214 suites  ±0   17m 58s ⏱️ -26s
  664 tests ±0    654 ✅ ±0  10 💤 ±0  0 ❌ ±0 
1 328 runs  ±0  1 306 ✅ ±0  22 💤 ±0  0 ❌ ±0 

Results for commit 04e9bea. ± Comparison against base commit 2b2cfa2.

♻️ This comment has been updated with latest results.

The TychoLifecycleMapping.EclipsePluginProjectConfigurator can call
getFolder() with a relative path which only seems to cause trouble on
Windows.
@HannesWell HannesWell force-pushed the relative-path-handling-in-config branch from 8434fed to 04e9bea Compare February 19, 2024 23:01
@HannesWell HannesWell merged commit 946c118 into eclipse-m2e:master Feb 19, 2024
7 checks passed
@HannesWell HannesWell deleted the relative-path-handling-in-config branch February 19, 2024 23:42
@HannesWell HannesWell added this to the 2.6.0 milestone Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant