Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable failing testcases related to Loom #15237

Merged
merged 1 commit into from
Jun 8, 2022
Merged

disable failing testcases related to Loom #15237

merged 1 commit into from
Jun 8, 2022

Conversation

fengxue-IS
Copy link
Contributor

Related: #15152

Signed-off-by: Jack Lu [email protected]

@tajila tajila requested a review from JasonFengJ9 June 6, 2022 19:10
@JasonFengJ9 JasonFengJ9 mentioned this pull request Jun 7, 2022
Merged
@JasonFengJ9
Copy link
Member

01:54:32 FAILURE - Copyright date in file: 'test/functional/cmdLineTests/jvmtitests/jvmtitests_excludes_19.xml' appears to be incorrect

Are we looking for more excludes to be added for a green sanity.functional?

@fengxue-IS
Copy link
Contributor Author

Are we looking for more excludes to be added for a green sanity.functional?

The only test failure in sanity.functional which I did not exclude is JDWP error which I am looking into fixing by adding the vmhook/event mapping for new JVMTI capability.

My build last night failed due to machine issue, will try to rerun the personal build to confirm

@fengxue-IS fengxue-IS force-pushed the exclude19 branch 2 times, most recently from 3c3fa5a to 62f5691 Compare June 7, 2022 14:53
@fengxue-IS
Copy link
Contributor Author

Personal build still in progress: Test_grinder/job/Grinder/24577/
will update PR once it completes

list of tests failed due to JDWP requiring new capability can_support_virtual_threads for reference:

cmdLineTester_jvmtitests_debug_1/2/3/4/5/6/7/8/9/10/11
cmdLineTester_jvmtitests_debug_openj9_none_SCC_1/2/3/4/5/6/7/8/9/10/11
decompileAtMethodResolve_0
cmdLineTester_jython_1/3/4/6
TestFlushReflectionCache_2

@tajila
Copy link
Contributor

tajila commented Jun 7, 2022

Okay, you can exlclude those as well, @babsingh is looking into JVMTI failures

@fengxue-IS fengxue-IS force-pushed the exclude19 branch 2 times, most recently from 2d2db9c to 824bf35 Compare June 8, 2022 05:58
JasonFengJ9
JasonFengJ9 reviewed Jun 8, 2022
View reviewed changes
test/functional/cmdLineTests/jvmtitests/playlist.xml
<version>19+</version>
<variation>Mode607-OSR</variation>
</disable>
</disables>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llxia is there a regex to disable test modes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is not supported atm. @renfeiw maybe we should add support for this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened an issue for this: adoptium/TKG#329 Will work on it later on.

@fengxue-IS fengxue-IS marked this pull request as ready for review June 8, 2022 15:19
@fengxue-IS
Copy link
Contributor Author

personal build passed on xlinux

@tajila
Copy link
Contributor

tajila commented Jun 8, 2022

jenkins test sanity amac jdknext

@tajila
Copy link
Contributor

tajila commented Jun 8, 2022

@llxia Please review these changes

llxia
llxia approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 8f40ad8 into eclipse-openj9:master Jun 8, 2022
This was referenced Jun 23, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renfeiw renfeiw renfeiw left review comments

@llxia llxia llxia approved these changes

@JasonFengJ9 JasonFengJ9 JasonFengJ9 approved these changes

@tajila tajila tajila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fengxue-IS @JasonFengJ9 @tajila @renfeiw @llxia