Merge pull request #531 from bjhargrave/stale-action

Stale action

.github/workflows/stale.yml

@@ -0,0 +1,70 @@
+#*******************************************************************************
+# Copyright (c) Contributors to the Eclipse Foundation
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+# SPDX-License-Identifier: Apache-2.0
+#*******************************************************************************
+
+name: Stale
+
+on:
+  schedule:
+    - cron: '30 1 * * *'
+
+env:
+  LC_ALL: en_US.UTF-8
+
+defaults:
+  run:
+    shell: bash
+
+permissions:
+  issues: write
+  pull-requests: write
+
+jobs:
+  stale:
+    name: Stale
+    runs-on: 'ubuntu-latest'
+    steps:
+    - name: Stale Action
+      uses: actions/stale@v5
+      with:
+        days-before-stale: 365
+        days-before-close: 21
+        exempt-all-milestones: true
+        stale-issue-label: 'stale'
+        stale-issue-message: >
+          This issue has been automatically marked as stale because it has not had recent activity.
+          Given the limited bandwidth of the team, it will be automatically closed if no further
+          activity occurs.
+          If you feel this is something you could contribute, please have a look
+          at our [Contributor Guide](https://github.com/osgi/osgi-test/blob/main/CONTRIBUTING.md).
+          Thank you for your contribution.
+        close-issue-message: >
+          This issue has been automatically closed due to inactivity. If you can reproduce this or
+          if you have a good use case for this feature, please feel free
+          to reopen the issue with steps to reproduce, a quick explanation of your use case or a
+          high-quality pull request.
+        stale-pr-label: 'stale'
+        stale-pr-message: >
+          This pull request has been automatically marked as stale because it has not had recent activity.
+          Given the limited bandwidth of the team, it will be closed if no further activity occurs.
+          If you intend to work on this pull request, please reopen the PR.
+          Thank you for your contributions.
+        close-pr-message: >
+          This pull request has been automatically closed due to inactivity.
+          If you are still interested in contributing this, please ensure that
+          it is rebased against the latest `main` branch, all review
+          comments have been addressed and the build is passing.

org.osgi.test.assertj.framework/src/main/java/org/osgi/test/assertj/dictionary/DictionaryAssert.java

@@ -44,8 +44,8 @@ public static <K, V> DictionaryAssert<K, V> assertThat(Dictionary<K, V> actual)
 
 	public static final <ACTUAL extends Dictionary<K, V>, K, V> InstanceOfAssertFactory<ACTUAL, DictionaryAssert<K, V>> dictionary(
 		Class<K> keyType, Class<V> valueType) {
-		requireNonNull(keyType, shouldNotBeNull("keyType").create());
-		requireNonNull(valueType, shouldNotBeNull("valueType").create());
+		requireNonNull(keyType, shouldNotBeNull("keyType")::create);
+		requireNonNull(valueType, shouldNotBeNull("valueType")::create);
 		@SuppressWarnings({
 			"unchecked", "rawtypes"
 		})

org.osgi.test.assertj.framework/src/main/java/org/osgi/test/assertj/servicereference/ServiceReferenceAssert.java

@@ -59,7 +59,7 @@ public static <SERVICE> ServiceReferenceAssert<SERVICE> assertThat(ServiceRefere
 	 */
 	public static <ACTUAL extends ServiceReference<? extends SERVICE>, SERVICE> InstanceOfAssertFactory<ACTUAL, ServiceReferenceAssert<SERVICE>> serviceReference(
 		Class<SERVICE> serviceType) {
-		requireNonNull(serviceType, shouldNotBeNull("serviceType").create());
+		requireNonNull(serviceType, shouldNotBeNull("serviceType")::create);
 		@SuppressWarnings({
 			"rawtypes", "unchecked"
 		})

org.osgi.test.assertj.framework/src/main/java/org/osgi/test/assertj/serviceregistration/ServiceRegistrationAssert.java

@@ -58,7 +58,7 @@ public static <SERVICE> ServiceRegistrationAssert<SERVICE> assertThat(
 	 */
 	public static <ACTUAL extends ServiceRegistration<? extends SERVICE>, SERVICE> InstanceOfAssertFactory<ACTUAL, ServiceRegistrationAssert<SERVICE>> serviceRegistration(
 		Class<SERVICE> serviceType) {
-		requireNonNull(serviceType, shouldNotBeNull("serviceType").create());
+		requireNonNull(serviceType, shouldNotBeNull("serviceType")::create);
 		@SuppressWarnings({
 			"rawtypes", "unchecked"
 		})

org.osgi.test.assertj.promise/src/main/java/org/osgi/test/assertj/promise/AbstractPromiseAssert.java

@@ -265,7 +265,7 @@ RESULT getValue(ACTUAL promise) {
 	 *             resolved with a failure.
 	 */
 	public AbstractObjectAssert<?, RESULT> hasValueThat() {
-		return isSuccessful().extracting(this::getValue, Assertions::<RESULT> assertThat);
+		return isSuccessful().extracting(this::getValue, Assertions::<RESULT> assertThatObject);
 	}
 
 	/**

org.osgi.test.assertj.promise/src/main/java/org/osgi/test/assertj/promise/PromiseAssert.java

@@ -68,7 +68,7 @@ public static <RESULT> PromiseAssert<RESULT> assertThat(Promise<? extends RESULT
 	 */
 	public static <ACTUAL extends Promise<? extends RESULT>, RESULT> InstanceOfAssertFactory<ACTUAL, PromiseAssert<RESULT>> promise(
 		Class<RESULT> resultType) {
-		requireNonNull(resultType, shouldNotBeNull("resultType").create());
+		requireNonNull(resultType, shouldNotBeNull("resultType")::create);
 		@SuppressWarnings({
 			"rawtypes", "unchecked"
 		})