Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using Eclipse Zenoh as transport between vehicle and back-end #36

Conversation

vivekpandey02
Copy link
Contributor

I am pleased to present a Pull Request marking the initiation of the Eclipse Zenoh integration into the Eclipse SDV FMS blueprint. This PR focuses on extending the FMS Forwarder to publish data via Zenoh, alongside configuring the Zenoh Router to receive data over MQTT. This integration sets the stage for the subsequent phase, where FMS consumer integration into the Zenoh Router will be addressed, further strengthening the capabilities of our Fleet Management System Blueprint. Please review the PR and provide the necessary feedback.

@eriksven
Copy link
Contributor

Hello,

thank you for the PR.

Regarding the failing the "Lint source code / lint-source-code" Check: We just created a PR in #37, which should fix this issue.

Regarding the ECA-Check: When I click on the details the same address is listed as covered once and as not covered 14 times. Could it be that. you signed the ECA after making the respective commits?

Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :-)
Am I right in assuming that the Zenoh router will currently not forward data to influx DB?

components/fms-forwarder/src/zenoh_publisher.rs Outdated Show resolved Hide resolved
fms-blueprint-compose.yaml Outdated Show resolved Hide resolved
fms-blueprint-compose-zenoh.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@eriksven
Copy link
Contributor

In the meantime we merged #37, so to resolve the linting error you can rebase to the current main-branch.

The issue with the ECA tool seems to have resolved itself in the meantime.

@evshary
Copy link

evshary commented Jan 18, 2024

Thanks for the PR :-) Am I right in assuming that the Zenoh router will currently not forward data to influx DB?

Not yet. I believe this is the next step. Maybe will use the Zenoh router with the influxdb plugin to forward data.

@vivekpandey02 vivekpandey02 force-pushed the fms-forwarder-zenoh-communication branch from 683bee4 to 515d762 Compare January 18, 2024 11:40
vivekpandey02 added a commit to vivekpandey02/fleet-management that referenced this pull request Jan 18, 2024
vivekpandey02 added a commit to vivekpandey02/fleet-management that referenced this pull request Jan 18, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
components/fms-forwarder/Cargo.toml Outdated Show resolved Hide resolved
components/fms-forwarder/Cargo.toml Outdated Show resolved Hide resolved
@sophokles73
Copy link
Contributor

@vivekpandey02 are you still working on this?

@vivekpandey02
Copy link
Contributor Author

@vivekpandey02 are you still working on this?

Yes, I am working on it. i have changed the FMS-Consumer for zenoh support. Now FMS Consumer can take the data from Hono Kafka and Zenoh both and write into influxDB. so we introduced Zenoh in FMS Forworder, and FMS-Consumer Both. I will merge my code into my PR#36 soon

vivekpandey02 added a commit to vivekpandey02/fleet-management that referenced this pull request Jan 30, 2024
vivekpandey02 added a commit to vivekpandey02/fleet-management that referenced this pull request Jan 30, 2024
@vivekpandey02 vivekpandey02 force-pushed the fms-forwarder-zenoh-communication branch from 55c35c9 to ca6ac96 Compare January 30, 2024 17:29
vivekpandey02 added a commit to vivekpandey02/fleet-management that referenced this pull request Jan 31, 2024
vivekpandey02 added a commit to vivekpandey02/fleet-management that referenced this pull request Jan 31, 2024
@vivekpandey02 vivekpandey02 force-pushed the fms-forwarder-zenoh-communication branch from ca6ac96 to 0d0bb22 Compare January 31, 2024 01:42
@vivekpandey02
Copy link
Contributor Author

@vivekpandey02 are you still working on this?

Hi @sophokles73, I have merged all the changes for Zenoh end to end communication in #PR36

@vivekpandey02
Copy link
Contributor Author

@vivekpandey02 are you still working on this?

Hi @sophokles73, I have merged all the changes for Zenoh end to end communication in #PR36

Hi @sophokles73, is there any comment / Feedback on PR #36 ?

Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay and thanks for adding the code for consuming data via Zenoh 👍

README.md Outdated Show resolved Hide resolved
components/Cargo.toml Outdated Show resolved Hide resolved
components/fms-consumer/src/main.rs Outdated Show resolved Hide resolved
components/fms-consumer/src/main.rs Outdated Show resolved Hide resolved
components/fms-consumer/src/main.rs Outdated Show resolved Hide resolved
fms-blueprint-compose-hono.yaml Outdated Show resolved Hide resolved
components/fms-consumer/README.md Outdated Show resolved Hide resolved
components/fms-consumer/README.md Outdated Show resolved Hide resolved
components/fms-consumer/README.md Outdated Show resolved Hide resolved
components/fms-consumer/README.md Outdated Show resolved Hide resolved
@vivekpandey02
Copy link
Contributor Author

Hello @sophokles73, I've incorporated the changes based on your review comments in my pull request.

Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good already 👍
Can you address the few (small) remaining issues? Then we can squash and merge ...

README.md Outdated Show resolved Hide resolved
components/fms-consumer/README.md Outdated Show resolved Hide resolved
components/fms-consumer/src/main.rs Outdated Show resolved Hide resolved
components/fms-consumer/src/main.rs Outdated Show resolved Hide resolved
components/Cargo.toml Outdated Show resolved Hide resolved
components/fms-forwarder/Cargo.toml Outdated Show resolved Hide resolved
@vivekpandey02 vivekpandey02 force-pushed the fms-forwarder-zenoh-communication branch from 8cf8977 to dab4baa Compare February 15, 2024 08:21
@vivekpandey02
Copy link
Contributor Author

vivekpandey02 commented Feb 15, 2024

Hi @sophokles73, I have done changes for the Zenoh Code for PR #36 as per your feedback.

@sophokles73 sophokles73 changed the title Fms forwarder zenoh communication Add support for using Eclipse Zenoh as transport between vehicle and back-end Feb 15, 2024
Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for contributing and your patience 👍

I have seen that you have undone your changes to Cargo.lock, which is fine, I will make the required changes after merging.
Do you want to squash your branch into a reasonable (small) number of commits, or should I do it when merging?

@vivekpandey02
Copy link
Contributor Author

LGTM

Thanks for contributing and your patience 👍

I have seen that you have undone your changes to Cargo.lock, which is fine, I will make the required changes after merging. Do you want to squash your branch into a reasonable (small) number of commits, or should I do it when merging?

You're welcome! I appreciate your guidance and patience throughout the process. I'm glad to contribute to the project. I trust your judgment, so if you could handle the squashing during the merging process, that would be fantastic. I appreciate your cooperation.

@sophokles73 sophokles73 merged commit 8bf2f16 into eclipse-sdv-blueprints:main Feb 15, 2024
2 checks passed
@eriksven eriksven mentioned this pull request Mar 14, 2024
@vivekpandey02 vivekpandey02 deleted the fms-forwarder-zenoh-communication branch March 15, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants