-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for using Eclipse Zenoh as transport between vehicle and back-end #36
Add support for using Eclipse Zenoh as transport between vehicle and back-end #36
Conversation
Hello, thank you for the PR. Regarding the failing the "Lint source code / lint-source-code" Check: We just created a PR in #37, which should fix this issue. Regarding the ECA-Check: When I click on the details the same address is listed as covered once and as not covered 14 times. Could it be that. you signed the ECA after making the respective commits? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR :-)
Am I right in assuming that the Zenoh router will currently not forward data to influx DB?
In the meantime we merged #37, so to resolve the linting error you can rebase to the current main-branch. The issue with the ECA tool seems to have resolved itself in the meantime. |
Not yet. I believe this is the next step. Maybe will use the Zenoh router with the influxdb plugin to forward data. |
683bee4
to
515d762
Compare
@vivekpandey02 are you still working on this? |
Yes, I am working on it. i have changed the FMS-Consumer for zenoh support. Now FMS Consumer can take the data from Hono Kafka and Zenoh both and write into influxDB. so we introduced Zenoh in FMS Forworder, and FMS-Consumer Both. I will merge my code into my PR#36 soon |
55c35c9
to
ca6ac96
Compare
ca6ac96
to
0d0bb22
Compare
Hi @sophokles73, I have merged all the changes for Zenoh end to end communication in #PR36 |
Hi @sophokles73, is there any comment / Feedback on PR #36 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay and thanks for adding the code for consuming data via Zenoh 👍
Hello @sophokles73, I've incorporated the changes based on your review comments in my pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good already 👍
Can you address the few (small) remaining issues? Then we can squash and merge ...
This reverts commit 1009a8c.
change the command from kafka to hono
8cf8977
to
dab4baa
Compare
Hi @sophokles73, I have done changes for the Zenoh Code for PR #36 as per your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for contributing and your patience 👍
I have seen that you have undone your changes to Cargo.lock, which is fine, I will make the required changes after merging.
Do you want to squash your branch into a reasonable (small) number of commits, or should I do it when merging?
You're welcome! I appreciate your guidance and patience throughout the process. I'm glad to contribute to the project. I trust your judgment, so if you could handle the squashing during the merging process, that would be fantastic. I appreciate your cooperation. |
I am pleased to present a Pull Request marking the initiation of the Eclipse Zenoh integration into the Eclipse SDV FMS blueprint. This PR focuses on extending the FMS Forwarder to publish data via Zenoh, alongside configuring the Zenoh Router to receive data over MQTT. This integration sets the stage for the subsequent phase, where FMS consumer integration into the Zenoh Router will be addressed, further strengthening the capabilities of our Fleet Management System Blueprint. Please review the PR and provide the necessary feedback.