Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed states-xtext example #108

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Removed states-xtext example #108

merged 1 commit into from
Jun 19, 2024

Conversation

spoenemann
Copy link
Contributor

The Xtext-based example doesn't work properly (#106 (review)), but we don't have the resources to keep maintaining it. The same functionality is now fully provided by the Langium-based example. Removing the older example also brings advantages for the project:

  • Less overall complexity (only one programming language and build system vs. two)
  • Faster build time (previous: 67s Java build + 42s Yarn build; now: 24s Yarn build – tested in Gitpod)
  • Fewer dependencies and lower maintenance effort

@spoenemann spoenemann requested a review from dhuebner June 17, 2024 09:37
@dhuebner
Copy link
Contributor

@spoenemann
It would be nice to have a tag 'xtext-example' (or a branch) that points to a commit that contains removed code. It could be helpful for people who want to interact with Xtext. WDYT?

Copy link
Contributor

@dhuebner dhuebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less code less maintenance.

@spoenemann spoenemann merged commit 78ba07a into master Jun 19, 2024
2 checks passed
@spoenemann spoenemann deleted the remove-states-xtext branch June 19, 2024 07:57
@spoenemann
Copy link
Contributor Author

I pushed a tag xtext-example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants