Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest): new endpoint /projects/myprojects #1824

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Feb 3, 2023

New /projects/myprojects to list projects for home page's "My Projects" table.

Please provide a summary of your changes here.

  • Which issue is this pull request belonging to and how is it solving it? (Refer to issue here)
  • Did you add or update any new dependencies that are required for your change?
    • No

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

How should these changes be tested by the reviewer?

Test the rest endpoint /projects/myprojects with various parameter combinations and compare the response with the UI.

Have you implemented any additional tests?

No

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@GMishx GMishx force-pushed the feat/rest/my-projects branch from 2fc4885 to 18dcdbe Compare February 3, 2023 09:55
@GMishx GMishx marked this pull request as ready for review February 8, 2023 09:12
@GMishx GMishx force-pushed the feat/rest/my-projects branch from 18dcdbe to 5f8d524 Compare February 8, 2023 10:35
@rudra-superrr
Copy link
Contributor

Was not able to get the desired result as there is bug in My Projects dropdown selection.
Refer issue : #1836

@rudra-superrr
Copy link
Contributor

Testing was successful.

@smrutis1
Copy link
Contributor

Please consider adding documentation

@GMishx GMishx force-pushed the feat/rest/my-projects branch from 5f8d524 to 5b8aa34 Compare March 1, 2023 08:15
@GMishx
Copy link
Member Author

GMishx commented Mar 1, 2023

Please consider adding documentation

Added the documentation @smrutis1 . Please have a look.

New `/projects/myprojects` to list projects for home page's "My
Projects" table.

Commit is related to issue eclipse-sw360#1826

Signed-off-by: Gaurav Mishra <[email protected]>
Signed-off-by: Gaurav Mishra <[email protected]>
@GMishx GMishx force-pushed the feat/rest/my-projects branch from 5b8aa34 to d707d7b Compare March 1, 2023 08:19
Copy link
Contributor

@smrutis1 smrutis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@smrutis1 smrutis1 added ready ready to merge and removed needs code review labels Mar 1, 2023
@ag4ums ag4ums merged commit f1871ba into eclipse-sw360:main Mar 3, 2023
@GMishx GMishx deleted the feat/rest/my-projects branch March 3, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants