Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Rest) : Advanced Search for project page #2851

Merged
merged 1 commit into from
Jan 27, 2025
Merged

feat(Rest) : Advanced Search for project page #2851

merged 1 commit into from
Jan 27, 2025

Conversation

keerthi-bl
Copy link
Contributor

@keerthi-bl keerthi-bl commented Dec 23, 2024 •
edited by GMishx
Loading

Issue:
Closes : #2832
Closes: #2854

Description

Rest end point added with following parameters for advance search in a project list page.

Version, Project responsible, State, Clearing State, additional Data.

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

URL : http://localhost:8080/resource/api/projects?name=update&version=1.1&state=PHASE_OUT&[email protected]

Response :
{

}

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@keerthi-bl keerthi-bl requested a review from GMishx December 23, 2024 09:37
@GMishx GMishx added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for New-UI Level for the API and UI level changes for the new-ui labels Dec 23, 2024
GMishx
GMishx requested changes Dec 23, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes for better documentation.

...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/project/ProjectController.java Outdated Show resolved Hide resolved
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/project/ProjectController.java Outdated Show resolved Hide resolved
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/project/ProjectController.java Outdated Show resolved Hide resolved
@GMishx
Copy link
Member

GMishx commented Dec 23, 2024

@keerthi-bl please fix the commit message as well.

@keerthi-bl keerthi-bl force-pushed the feat/advSearchForProjectRest branch 2 times, most recently from 6319c03 to eb9a778 Compare December 24, 2024 04:41
@keerthi-bl keerthi-bl changed the title Advanced Search for project page feat(Rest) : Advanced Search for project page Dec 24, 2024
@keerthi-bl keerthi-bl force-pushed the feat/advSearchForProjectRest branch from eb9a778 to 1537205 Compare December 24, 2024 06:20
GMishx
GMishx approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

GMishx
GMishx requested changes Jan 3, 2025
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change needed.

During testing, discovered another issue. The function call to getProjectsForUser() (when lucene is false) gives wrong amount of projects (always 20). Will open a separate issue for the same.

...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/project/ProjectController.java Outdated Show resolved Hide resolved
@GMishx
Copy link
Member

GMishx commented Jan 3, 2025

Created separate issue #2854 .

Please fix the changes requested for merging this pr.

@keerthi-bl keerthi-bl force-pushed the feat/advSearchForProjectRest branch from 1537205 to 8cb56c0 Compare January 20, 2025 08:43
@keerthi-bl
Copy link
Contributor Author

Created separate issue #2854 .

Please fix the changes requested for merging this pr.

@GMishx
This issue has been fixed and pushed in the same branch here.

GMishx
GMishx approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

GMishx
GMishx approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx added ready ready to merge and removed needs general test This is general testing, meaning that there is no org specific issue to check for labels Jan 27, 2025
@GMishx GMishx merged commit 2d0664f into eclipse-sw360:main Jan 27, 2025
3 checks passed
@GMishx GMishx deleted the feat/advSearchForProjectRest branch January 27, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

@heliocastro heliocastro Awaiting requested review from heliocastro heliocastro is a code owner

@KoukiHama KoukiHama Awaiting requested review from KoukiHama KoukiHama is a code owner

@arunazhakesan arunazhakesan Awaiting requested review from arunazhakesan arunazhakesan is a code owner

@ag4ums ag4ums Awaiting requested review from ag4ums ag4ums is a code owner

Assignees
No one assigned
Labels
New-UI Level for the API and UI level changes for the new-ui ready ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project filter with luceneSearch false gives wrong pagination feat(REST) : Advanced Search for project page.
2 participants
@keerthi-bl @GMishx