feat(rest): endpoint to merge vendor. #2870
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudra-superrr
requested review from
heliocastro,
GMishx,
KoukiHama,
arunazhakesan and
ag4ums
as code owners
rudra-superrr
added
needs code review
needs general test
GMishx
requested changes
Jan 27, 2025
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/vendor/Sw360VendorService.java
Outdated
Show resolved
Hide resolved
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/vendor/Sw360VendorService.java
Outdated
Show resolved
Hide resolved
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/vendor/Sw360VendorService.java
Outdated
Show resolved
Hide resolved
rudra-superrr
force-pushed
the
feat/mergeVendor
branch
3 times, most recently
from
540da4b to
685d793
Compare
Signed-off-by: Rudra Chopra <[email protected]>
rudra-superrr
force-pushed
the
feat/mergeVendor
branch
from
685d793 to
8c8359b
Compare
|
Made the changes. |
GMishx
requested changes
Jan 31, 2025
| requestStatus = sw360VendorClient.mergeVendors(vendorTargetId, vendorSourceId, vendorSelection, user); | ||
|
|
||
| if (requestStatus == RequestStatus.IN_USE) { | ||
| throw new HttpMessageNotReadableException("Vendor already in use as source or target vendor has an open MR"); |
There was a problem hiding this comment.
Suggested change
| throw new HttpMessageNotReadableException("Vendor already in use as source or target vendor has an open MR"); | |
| throw new HttpMessageNotReadableException("Vendor used as source or target has an open MR"); |
| summary = "Merge two vendors.", | ||
| description = "Merge source vendor into target vendor.", | ||
| tags = {"Vendor"} | ||
| ) |
There was a problem hiding this comment.
Please document the possible response codes generated by this endpoint (which are 4 possible ways).
You can refer to other endpoints documenting the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2869
Description: this new endpoint will merge the source vendor to the target vendor.