Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Rest): new endpoint will help to get the package details by projectID #2893

Merged
merged 1 commit into from
Feb 5, 2025
Merged

fix(Rest): new endpoint will help to get the package details by projectID #2893

merged 1 commit into from
Feb 5, 2025

Conversation

nikkuma7
Copy link
Contributor

@nikkuma7 nikkuma7 commented Jan 29, 2025 •
edited
Loading

…ctId.

Please provide a summary of your changes here.

  • Which issue is this pull request belonging to and how is it solving it? (Refer to issue here)
  • Did you add or update any new dependencies that are required for your change?

Issue: Closes #2896

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

get: http://localhost:8080/resource/api/projects/{projectId}/packages

How should these changes be tested by the reviewer?
Have you implemented any additional tests?

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@smrutis1 smrutis1 added the WIP work in progress label Jan 29, 2025
@nikkuma7 nikkuma7 force-pushed the feat/getPackagebyProjectId branch 2 times, most recently from 021356c to 210053c Compare January 30, 2025 07:18
@nikkuma7 nikkuma7 added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for and removed WIP work in progress labels Jan 30, 2025
@GMishx
Copy link
Member

GMishx commented Jan 31, 2025

I didn't had time to test this PR but @nikkuma7 the changes looks like this endpoint will return lot of additional data along with the package info. This endpoint should only return the linked packages and nothing else to keep it lightweight. Please confirm if the output is inline with the same.

@nikkuma7
Copy link
Contributor Author

@GMishx , Hi Gaurav, only the package details are appearing in the response.

See the response below:

image
image

The project ID 2bf2cd2fb522c85dd7dac44eb64ffac2 has two packages added, but only the package details are being returned in the response.

@nikkuma7
Copy link
Contributor Author

response.txt

GMishx
GMishx previously approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good

@GMishx
Copy link
Member

GMishx commented Jan 31, 2025

@amritkv please test this PR

@amritkv
Copy link

amritkv commented Feb 3, 2025 •
edited
Loading

@amritkv please test this PR

@GMishx Vendor Id and Vendor Name seems to be missing.

@nikkuma7 nikkuma7 force-pushed the feat/getPackagebyProjectId branch from 210053c to 203f20e Compare February 4, 2025 06:59
@nikkuma7
Copy link
Contributor Author

nikkuma7 commented Feb 4, 2025

Vendor Id and Vendor Name seems to be missing.
@amritkv @GMishx , vendor Id and details added.
respone_pa ckage_vendor.txt

@amritkv
Copy link

amritkv commented Feb 4, 2025

Vendor Id and Vendor Name seems to be missing.
@amritkv @GMishx , vendor Id and details added.
respone_pa ckage_vendor.txt

@GMishx @nikkuma7 LGTM !

GMishx
GMishx approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @amritkv

@GMishx GMishx added ready ready to merge and removed needs general test This is general testing, meaning that there is no org specific issue to check for labels Feb 5, 2025
@GMishx GMishx merged commit 48f9159 into eclipse-sw360:main Feb 5, 2025
3 checks passed
@GMishx GMishx deleted the feat/getPackagebyProjectId branch February 5, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

@heliocastro heliocastro Awaiting requested review from heliocastro heliocastro is a code owner

@KoukiHama KoukiHama Awaiting requested review from KoukiHama KoukiHama is a code owner

@arunazhakesan arunazhakesan Awaiting requested review from arunazhakesan arunazhakesan is a code owner

@ag4ums ag4ums Awaiting requested review from ag4ums ag4ums is a code owner

Assignees

@amritkv amritkv

Labels
ready ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(Rest): new endpoint will help to get the package details by projectID.
4 participants
@nikkuma7 @GMishx @amritkv @smrutis1