feat: support readonly property ThemeColor id (#14437)

fix #14404 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <[email protected]>
eclipse-theia · Nov 14, 2024 · 017e12e · 017e12e
1 parent d769658
commit 017e12e
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,8 @@
 
 <!-- ## 1.56.0 - not yet released -->
 
+- [plugin] added support for ThemeColor property id [#14437](https://github.com/eclipse-theia/theia/pull/14437) - Contributed on behalf of STMicroelectronics
+
 ## 1.55.0 - 10/31/2024
 
 - [ai] added logic to allow to order and clear AI History view [#14233](https://github.com/eclipse-theia/theia/pull/14233)

diff --git a/packages/core/src/common/theme.ts b/packages/core/src/common/theme.ts
@@ -38,7 +38,7 @@ export interface ThemeChangeEvent {
 }
 
 export interface ThemeColor {
-    id: string;
+    readonly id: string;
 }
 
 export interface ThemeIcon {

diff --git a/packages/plugin-ext/src/plugin/types-impl.ts b/packages/plugin-ext/src/plugin/types-impl.ts
@@ -725,7 +725,7 @@ export class SnippetString {
 
 @es5ClassCompat
 export class ThemeColor {
-    constructor(public id: string) { }
+    constructor(public readonly id: string) { }
 }
 
 @es5ClassCompat

diff --git a/packages/plugin/src/theia.d.ts b/packages/plugin/src/theia.d.ts
@@ -2696,6 +2696,11 @@ export module '@theia/plugin' {
      * Using a theme color is preferred over a custom color as it gives theme authors and users the possibility to change the color.
      */
     export class ThemeColor {
+        /**
+         * The id of this color.
+         */
+        readonly id: string;
+
         /**
          * Creates a reference to a theme color.
          */