-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use npm instead of yarn to build Theia #14481
base: master
Are you sure you want to change the base?
Changes from all commits
c5b0db8
c64dfcb
4ac4643
a5080ac
312bd04
abbaf15
ef7d5e7
e2dd83b
d4e23a9
51bacae
7e91fb2
977c252
8112326
e37f2b5
1c22140
5336f62
82b7da0
3e668e8
dd67398
f9589e7
bdb6fb6
469782c
6163af0
652efeb
37d8330
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,6 @@ | ||
root = true | ||
|
||
[*] | ||
insert_final_newline = true | ||
end_of_line = lf | ||
indent_style = space | ||
|
||
|
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
dev-packages/*/bin/*.js text eol=lf |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,16 +34,16 @@ jobs: | |
- name: Install and Build | ||
shell: bash | ||
run: | | ||
yarn global add node-gyp | ||
yarn --skip-integrity-check --network-timeout 100000 | ||
npm install -g node-gyp | ||
npm install | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should use |
||
./scripts/check_git_status.sh | ||
env: | ||
NODE_OPTIONS: --max_old_space_size=4096 | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9 | ||
|
||
- name: Lint | ||
run: | | ||
yarn lint | ||
npm run lint | ||
|
||
build: | ||
name: Build and Test (${{ matrix.os }}, node-${{ matrix.node }}) | ||
|
@@ -72,44 +72,38 @@ jobs: | |
with: | ||
python-version: '3.11' | ||
|
||
- name: Install | ||
- name: Build | ||
shell: bash | ||
run: | | ||
yarn global add node-gyp | ||
yarn --skip-integrity-check --network-timeout 100000 | ||
npm install -g node-gyp | ||
npm install | ||
npm run build | ||
git status | ||
./scripts/check_git_status.sh | ||
env: | ||
NODE_OPTIONS: --max_old_space_size=4096 | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9 | ||
|
||
|
||
- name: Download Plugins | ||
if: runner.os == 'Linux' | ||
shell: bash | ||
run: | | ||
yarn -s download:plugins --rate-limit 3 | ||
|
||
- name: Build | ||
shell: bash | ||
run: | | ||
yarn build:examples | ||
./scripts/check_git_status.sh | ||
env: | ||
NODE_OPTIONS: --max_old_space_size=4096 | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9 | ||
|
||
npm run download:plugins -- --rate-limit 3 | ||
|
||
- name: Test (headless) | ||
if: matrix.tests != 'skip' | ||
shell: bash | ||
run: | | ||
yarn browser rebuild | ||
yarn test:theia | ||
npm run rebuild:browser | ||
npm run test:theia | ||
|
||
- name: Test (browser) | ||
if: matrix.tests != 'skip' && runner.os == 'Linux' | ||
run: | | ||
xvfb-run -a yarn browser test | ||
xvfb-run -a npm run test:browser | ||
|
||
- name: Test (electron) | ||
if: matrix.tests != 'skip' && runner.os == 'Linux' | ||
run: | | ||
xvfb-run -a yarn electron test | ||
xvfb-run -a npm run test:electron |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,4 +48,4 @@ jobs: | |
if: matrix.tests != 'skip' | ||
shell: bash | ||
run: | | ||
yarn license:check | ||
npm run license:check |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep this? Why remove it?