Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Theia AI ]Allow canceling llama-file requests #14515

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[Theia AI ]Allow canceling llama-file requests #14515

merged 1 commit into from
Nov 25, 2024

Conversation

JonasHelming
Copy link
Contributor

fixed #14514

What it does

LamaFile Requests can be canceled

How to test

  • Start a llamafile
  • Do a request in the chat or via code completion
  • Cancel the request (via button in the chat or via moving he cursor when auto-completing)
  • Observe request gets canceled in the output view

Review checklist

Reminder for reviewers

@JonasHelming
Allow canceling llama-file requests
930c669 
fixed #14514

Signed-off-by: Jonas Helming <[email protected]>
eneufeld
eneufeld approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@eneufeld eneufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

martin-fleck-at
martin-fleck-at approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JonasHelming JonasHelming merged commit 7b2cde9 into master Nov 25, 2024
11 checks passed
@github-actions github-actions bot added this to the 1.56.0 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-fleck-at martin-fleck-at martin-fleck-at approved these changes

@eneufeld eneufeld eneufeld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Backlog
Archived in project
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.

Llama-file requests cannot be canceled
3 participants
@JonasHelming @eneufeld @martin-fleck-at