Dev Container uses the right workspace now #14557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are more than one workspaces open the config json is picked from the right workspace. Solves #14307
|
The linting task still fails |
jonah-iden
approved these changes
Nov 29, 2024
msujew
reviewed
Nov 29, 2024
| @@ -54,7 +49,7 @@ export class DevContainerFileService { | |||
| } | |||
|
|
|||
| protected async searchForDevontainerJsonFiles(directory: string, depth: number): Promise<string[]> { | |||
| if (depth < 0) { | |||
| if (depth < 0 || !fs.existsSync(directory)) { | |||
There was a problem hiding this comment.
Please don't use sync file system code in the backend - it blocks the whole server process and is bad practice.
There was a problem hiding this comment.
sorry overlooked that. PR here #14563
|
Just an FYI, this doesn’t seem to work on the Theia IDE Preview for 1.57 at the moment. We haven’t investigated yet: #14643 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
When there are more than one workspaces open the config json is picked from the right workspace.
Solves #14307
How to test
See #14307 and try to reproduce the issue. Should not be possible anymore. :-)
Review checklist
Reminder for reviewers