Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add initial support for query parameters to exploreDirectory method #94

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Jan 5, 2024

As currently discussed in w3c/wot-scripting-api#528, this PR adds initial experimental support for the three query parameters offset, limit, and format to the exploreDirectory method.

At the moment only the format value array is supported, with the value collection left open for a follow-up PR. While implementing, however, I noticed that the current approach does not allow for an elegant passing of the next links (from the HTTP response headers) to the upper layers of the library.

Not only in the context of dart_wot but also for node-wot we could therefore discuss expanding the Content class/interface to be able to pass this information alongside the payload data. However, there is probably some discussion needed to do this in a protocol-agnostic manner.

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7adfed6) 67.24% compared to head (17334a9) 67.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   67.24%   67.37%   +0.12%     
==========================================
  Files          69       70       +1     
  Lines        2265     2274       +9     
==========================================
+ Hits         1523     1532       +9     
  Misses        742      742              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JKRhb JKRhb force-pushed the explore-directory-variables branch from a95815d to 9e1385d Compare January 5, 2024 18:54
@JKRhb JKRhb force-pushed the explore-directory-variables branch from 9e1385d to d909d2f Compare January 5, 2024 18:59
@JKRhb JKRhb changed the title feat: add support for query parameters to exploreDirectory method feat!: add support for query parameters to exploreDirectory method Jan 5, 2024
@JKRhb JKRhb changed the title feat!: add support for query parameters to exploreDirectory method feat!: add initial support for query parameters to exploreDirectory method Jan 5, 2024
@JKRhb JKRhb force-pushed the explore-directory-variables branch from d92f710 to 17334a9 Compare January 5, 2024 21:01
@JKRhb JKRhb marked this pull request as ready for review January 5, 2024 21:01
@JKRhb JKRhb enabled auto-merge January 5, 2024 21:02
@JKRhb JKRhb merged commit 8b7e826 into main Jan 5, 2024
4 checks passed
@JKRhb JKRhb deleted the explore-directory-variables branch January 5, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants