detect phantom dependencies and fix

[hasanheroglu]

Closes #1319.

As @relu91 mentioned, separating CI runs gets complicated and doesn't match the logic of a monorepo. I found a better and simpler solution: adding import/no-extraneous-dependencies to eslint configuration.

This lint config deals with "phantom dependencies" and gives an error if they exist.

[JKRhb]

Thank you, @hasanheroglu, that looks very promising :) I am wondering, though: Does this PR make the comon devDependencies in the top-level package.json obsolete? If so, then that section could probably be removed.

Consdering the conflicts, you may need to rebase your branch against master to resolve them.

[hasanheroglu]

Thank you, @hasanheroglu, that looks very promising :) I am wondering, though: Does this PR make the comon devDependencies in the top-level package.json obsolete? If so, then that section could probably be removed.

I just realized I didn't add devDependencies for types in the packages. I can add them and then remove the obsolete dependencies from the root.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.46%. Comparing base (36b3f79) to head (91ada19).
Report is 27 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1321      +/-   ##
==========================================
+ Coverage   76.26%   77.46%   +1.19%     
==========================================
  Files          82       83       +1     
  Lines       15946    16576     +630     
  Branches     1603     1667      +64     
==========================================
+ Hits        12162    12841     +679     
+ Misses       3731     3678      -53     
- Partials       53       57       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[relu91]

Great, that's an ingenuous move 👍🏻 well done. The only problem that I see is that having dev deps in the root package.json help with the consistency of the dev tools among all packages... however, I always feel that is not a big deal since every package could in theory be developed differently than the others (with different dev tools). @danielpeintner what do you think?

[hasanheroglu]

Great, that's an ingenuous move 👍🏻 well done. The only problem that I see is that having dev deps in the root package.json help with the consistency of the dev tools among all packages... however, I always feel that is not a big deal since every package could in theory be developed differently than the others (with different dev tools). @danielpeintner what do you think?

Actually, we can configure the lint rule to apply only to product dependencies. Therefore, we don't need to change any devDependencies, and it shouldn't cause any issues for the package users.

[danielpeintner]

however, I always feel that is not a big deal since every package could in theory be developed differently than the others (with different dev tools). @danielpeintner what do you think?

I still think it would be better to keep the versions consistent. Apart from the package.json in root I think the following script should check the consistency also, right?

node-wot/package.json

Line 31 in 99b8303

"check:versions": "node utils/check_package_version_consistency.js",

We do run it also on the CI workflow.

node-wot/.github/workflows/ci.yaml

Line 90 in 99b8303

version_consistency:

This makes me think that we do not really need package.json in the root, right?

[relu91]

This makes me think that we do not really need package.json in the root, right?

It is still required for generic monorepo configuration and lifecycle scripts, but where to list dev dependencies is completely up to us.

[relu91]

Anyhow I forgot to approve the PR.

[hasanheroglu]

So I added eslint configs, that extend the root config override "no-extraneous-dependencies" rule, to test directories. Therefore, the rule only applies to the product dependencies and we can share common devDependencies in the root package.json.

[JKRhb]

Thank you, @hasanheroglu!

[relu91]

thanks!!!