Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use interface for WoT.consume() #1332

Merged
merged 2 commits into from
Nov 11, 2024
Merged

refactor: Use interface for WoT.consume() #1332

merged 2 commits into from
Nov 11, 2024

Conversation

danielpeintner
Copy link
Member

fixes #1331

@danielpeintner
Copy link
Member Author

Interesting that CI fails for "version consistency" ... I didn't even touch anything related

@danielpeintner danielpeintner changed the title refactor: Use interface for consume refactor: Use interface for WoT.consume() Nov 8, 2024
relu91
relu91 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this is a change of the interface... therefore we should publish a minor next. The changes are fine, I appreciate the fact that we are now consistent. Weird that the CI broke even if you didn't introduce any new dep.

@relu91 relu91 merged commit d6d25d3 into eclipse-thingweb:master Nov 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relu91 relu91 relu91 approved these changes

@JKRhb JKRhb Awaiting requested review from JKRhb JKRhb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WoT consume returns an implementation instead of an interface
2 participants
@danielpeintner @relu91