Save intermediate text encoded buffer copies

eclipse-vertx · Nov 18, 2024 · 4c38e2d · 4c38e2d
1 parent 21498ca
commit 4c38e2d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/vertx-core/src/main/java/io/vertx/core/http/impl/WebSocketImplBase.java b/vertx-core/src/main/java/io/vertx/core/http/impl/WebSocketImplBase.java
@@ -40,6 +40,7 @@
 
 import javax.net.ssl.SSLPeerUnverifiedException;
 import javax.net.ssl.SSLSession;
+import java.nio.charset.StandardCharsets;
 import java.security.cert.Certificate;
 import java.util.List;
 import java.util.UUID;
@@ -239,7 +240,13 @@ public Future<Void> writeBinaryMessage(Buffer data) {
 
   @Override
   public Future<Void> writeTextMessage(String text) {
-    return writePartialMessage(WebSocketFrameType.TEXT, Buffer.buffer(text), 0);
+    byte[] utf8Bytes = text.getBytes(StandardCharsets.UTF_8);
+    boolean isFinal = utf8Bytes.length <= maxWebSocketFrameSize;
+    if (isFinal) {
+      return writeFrame(new WebSocketFrameImpl(WebSocketFrameType.TEXT, utf8Bytes, true));
+    }
+    // we could save to copy the byte[] if the unsafe heap version of Netty ByteBuf could expose wrapping byte[] directly
+    return writePartialMessage(WebSocketFrameType.TEXT, Buffer.buffer(utf8Bytes), 0);
   }
 
   @Override

diff --git a/vertx-core/src/main/java/io/vertx/core/http/impl/ws/WebSocketFrameImpl.java b/vertx-core/src/main/java/io/vertx/core/http/impl/ws/WebSocketFrameImpl.java
@@ -80,6 +80,15 @@ public WebSocketFrameImpl(String textData) {
     this(textData, true);
   }
 
+  /**
+   * Creates a new raw frame from with the specified encoded content.
+   */
+  public WebSocketFrameImpl(WebSocketFrameType type, byte[] utf8TextData, boolean isFinalFrame) {
+    this.type = type;
+    this.isFinalFrame = isFinalFrame;
+    this.binaryData = Unpooled.wrappedBuffer(utf8TextData);
+  }
+
   /**
    * Creates a new text frame from with the specified string.
    */