-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add peer host and port info for server SslHandler (4.x) #5346
Conversation
looks good but I'd prefer use vertx type |
@vietj Hmm... I'm not sure if it worth to do this extra conversion... it adds overhead... Anyway, I'll try to use |
2fb56be
to
ca87366
Compare
@vietj I updated the PR to use |
ca87366
to
8e829dd
Compare
Hmm... looks like the vertx gen failed... sorry that I didn't notice it when testing in my IDE... seems it didn't do the vertx gen... |
@vietj Could you review? If it looks good to you, I'll update the PR for master branch to also use the |
8e829dd
to
07c9e22
Compare
@vietj I moved the conversion method to |
@ben1222 thank you, can you port the changes to master ? |
@ben1222 it sounds reasonnable to do early november a 4.5.11 release given that there is a fair amount of issues which have been fixed |
Fixes #5290 , on 4.x branch.