Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the preferred content format for Bootstrap-Request #443

Closed

Conversation

sbertin-telular
Copy link
Contributor

Includes changes from #423, #430, #431, #432, and #435. Those should be merged before this. The changes intended for this are in 04e8219.

sbertin-telular and others added 23 commits February 14, 2019 11:23
Provides an improved range of conversions and handles scientific
notation.

Updates the tests.

Ignores warning about comparing floating point numbers for equality.
This is intentionally used to detect a NaN.

Signed-off-by: Scott Bertin <[email protected]>
It is always enabled for LWM2M 1.0 clients and servers and LWM2M 1.1
servers, but disabled by default for LWM2M 1.1 clients.

Signed-off-by: Scott Bertin <[email protected]>
size_t can be 64-bits while unsigned int is smaller. This causes issues
when option_length is accessed through the pointer x in
coap_parse_message(). The option length and delta are at most a 16-bit
unsigned integer plus 269 according to RFC 7252. Changing
option_number, option_delta, and option_length to uint32_t and x to
uint32_t * fixes eclipse-wakaama#429. This also ensures sufficient size even if used
on a platform with smaller integers.

Signed-off-by: Scott Bertin <[email protected]>
Observe cancel responses from the client and Create requests from the
server were hard coded to use TLV.

Observe cancel will now respect the format in the accept option or use
the preferred format of the client if there is no accept option.

Create requests will now use the preferred client format except when no
object instance is specified. JSON and SenML JSON formats do not parse
or serialize properly with a missing object instance, so TLV is forced
in that case until it is fixed.


Signed-off-by: Scott Bertin <[email protected]>
Fix problem serializing resource instance reads.
Fix handling of empty strings and opaque.
Fix JSON serializing single instance resource as multiple. Fixes eclipse-wakaama#378.
Fix JSON parsing of multiple instance resources. Fixes eclipse-wakaama#399.

Signed-off-by: Scott Bertin <[email protected]>
Fixes eclipse-wakaama#332 and prepares for writes of individual resource instances.

Signed-off-by: Scott Bertin <[email protected]>
@sbertin-telular
Copy link
Contributor Author

This got ugly fast. I'll close this and wait until I can create a pull request that is cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant