Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lw/client examples as individual projects #818

Conversation

LukasWoodtli
Copy link
Contributor

@LukasWoodtli LukasWoodtli commented Oct 31, 2024

The client example projects now use Wakaama as a direct dependency. They
have also been split into three different projects (udp, tinydtls and
raw_block1). The CI and integration tests were adjusted for the new
project.

@LukasWoodtli LukasWoodtli force-pushed the lw/client_examples_as_individual_projects branch from 69eec22 to 89e4bc7 Compare October 31, 2024 08:47
@LukasWoodtli LukasWoodtli force-pushed the lw/client_examples_as_individual_projects branch 2 times, most recently from 372bb30 to 8b2305c Compare October 31, 2024 20:11
@LukasWoodtli LukasWoodtli marked this pull request as ready for review November 5, 2024 08:05
@LukasWoodtli LukasWoodtli requested a review from mlasch November 5, 2024 08:05
Copy link
Contributor

@rettichschnidi rettichschnidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a (very) brief look and noticed the following CMake warnings that did not show up before:

CMake Warning:
  Manually-specified variables were not used by the project:

    WAKAAMA_ENABLE_EXAMPLES

Will have a close(r) look once this is resolved.

@LukasWoodtli
Copy link
Contributor Author

Just had a (very) brief look and noticed the following CMake warnings that did not show up before:

CMake Warning:
  Manually-specified variables were not used by the project:

    WAKAAMA_ENABLE_EXAMPLES

Will have a close(r) look once this is resolved.

Thank you for the hint. Removing that is part of the next PR (wip) with some clean-ups.
I decided to split a bigger change (#808) into smaller ones for better reviewing.

@rettichschnidi rettichschnidi self-requested a review November 27, 2024 15:16
Copy link
Contributor

@rettichschnidi rettichschnidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on latest main before merging. The CI might fail then:

$ git rebase upstream/main 
 .github/workflows/build.yaml                 |   8 ++++++--
 .github/workflows/build_and_test.yaml        |   9 ++++++---
 .github/workflows/clang-static-analyzer.yaml |   8 ++++++--
 .github/workflows/codeql-analysis.yml        |  10 +++++++---
 .github/workflows/compliance.yaml            |   8 ++++++--
 .github/workflows/coverage.yaml              |   8 ++++++--
 .github/workflows/documentation.yaml         |   8 ++++++--
 .github/workflows/macos.yaml                 |   6 +++++-
 .github/workflows/multiarch.yaml             |   8 ++++++--
 .github/workflows/scorecard.yml              |  61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 .github/workflows/sonarcloud-scan.yaml       |   8 ++++++--
 CONTRIBUTING.md                              |   2 +-
 NOTICE.md                                    |   2 +-
 README.md                                    |  22 ++++++++++++---------
 doc/wakaama_features.rst                     | 213 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 examples/shared/platform.c                   |   2 +-
 tests/data_senml_json_tests.c                |   2 +-
 tests/integration/requirements.txt           |  15 ++++++++++++--
 tools/ci/run_ci.sh                           |   5 +++--
 tools/requirements-compliance.txt            |  31 ++++++++++++++++++++++++++---
 20 files changed, 395 insertions(+), 41 deletions(-)
 create mode 100644 .github/workflows/scorecard.yml
 create mode 100644 doc/wakaama_features.rst
Successfully rebased and updated refs/heads/lw/client_examples_as_individual_projects.
$ tools/ci/run_ci.sh --all
no modified files to format
diff --git a/examples/client/common/object_firmware.c b/examples/client/common/object_firmware.c
index aa39a6c..8631cd9 100644
--- a/examples/client/common/object_firmware.c
+++ b/examples/client/common/object_firmware.c
@@ -59,7 +59,7 @@
 #define RES_M_UPDATE_METHOD 9
 
 #define LWM2M_FIRMWARE_PROTOCOL_NUM 4
-#define LWM2M_FIRMWARE_PROTOCOL_NULL ((uint8_t) - 1)
+#define LWM2M_FIRMWARE_PROTOCOL_NULL ((uint8_t)-1)
 
 typedef struct {
     uint8_t state;

The client example projects now use Wakaama as a direct dependency. They
have also been split into three different projects (udp, tinydtls and
raw_block1). The CI and integration tests were adjusted for the new
project.
@LukasWoodtli LukasWoodtli force-pushed the lw/client_examples_as_individual_projects branch from e841a44 to be1ae59 Compare November 28, 2024 09:49
@LukasWoodtli
Copy link
Contributor Author

Please rebase on latest main before merging.

Done

@LukasWoodtli LukasWoodtli merged commit 9ee63a2 into eclipse-wakaama:main Dec 3, 2024
36 checks passed
@LukasWoodtli LukasWoodtli deleted the lw/client_examples_as_individual_projects branch December 3, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants