-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add CodeChecker #836
ci: Add CodeChecker #836
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
2104d0c
to
dfb77f1
Compare
How about removing https://github.com/eclipse-wakaama/wakaama/blob/main/.github/workflows/clang-static-analyzer.yaml in the same PR? |
Good point! |
1a59e6f
to
56a3853
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial, superfluous feedback. Will have a closer look once I get it to work on my machine.
.github/workflows/codechecker.yaml
Outdated
run: | | ||
sudo apt-get update | ||
sudo apt-get install clang-tools-18 cmake cppcheck libcunit1-dev ninja-build | ||
pip3 install codechecker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would lock down all dependencies
pip3 install codechecker | |
pip install --require-hashes -r tools/requirements-ci.txt |
Warning: CodeChecker has quite some dependencies, this will be a rabbit hole. But maybe you'll find good tooling for this work?
tools/ci/run_ci.sh
Outdated
CodeChecker check --logfile build-wakaama/compile_commands.json \ | ||
--config "$config_file" \ | ||
--ignore "$ignore_file" \ | ||
--output $code_checker_result_dir \ | ||
|| true # Currently failing with found issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needed? If it does, would improve the comment, explain a bit.
9eee1a7
to
14dfba3
Compare
CodeChecker combines multiple static code analysis tools including `clang-sa`. It also provides the possibility to check against a baseline to report only newly introduced issues. Moreover it is simpler to use. It could eventually replace `clang-sa` completely in the pipeline.
Static analysis is done with `CodeChecker` now. It integrates the clang static analyzer and `cppcheck`.
14dfba3
to
3f1a5b9
Compare
|
No description provided.