Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oomph clean build onlyNewProjects="true" #3020

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

LorenzoBettini
Copy link
Contributor

This should deal with the problem of always getting a clean build in Windows, each time you open the development workspace.

See #2778 (comment)

This should deal with the problem of always getting a clean build in Windows, each time you open the development workspace.

See #2778 (comment)
Copy link
Contributor

@cdietrich cdietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately i cannot test this only any system if there are bad side effect

@LorenzoBettini
Copy link
Contributor Author

unfortunately i cannot test this only any system if there are bad side effect

What I verified on Windows is that

  • on the first Oomph run, all projects are effectively clean-built
  • when restarting Eclipse the clean build does not happen, since everything is seen as up-to-date

Since I had no problems in Linux and macOS, I don't think this will cause any side effect.

As @merks suggested in #2778 (comment) this should be the correct setting

@LorenzoBettini LorenzoBettini added this to the Release_2.35 milestone Apr 29, 2024
@LorenzoBettini LorenzoBettini merged commit 655cdc1 into main Apr 29, 2024
10 checks passed
@LorenzoBettini LorenzoBettini deleted the LorenzoBettini-patch-1 branch April 29, 2024 19:22
@LorenzoBettini
Copy link
Contributor Author

@merks on a second thought, I guess the problem fixed by this PR wasn't happening on macOS and Linux because in those machines I have this user setting:

image

can it be?

@merks
Copy link
Contributor

merks commented Apr 30, 2024

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants