New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove C++17 incompatible designated initializers from headers [Bug] #352

Closed

milyin opened this issue Feb 23, 2024 · 0 comments · Fixed by #354

Labels

bug

Contributor

milyin commented Feb 23, 2024 •

edited

Loading

When compiling zenoh-pico with C++ compiler the following error appears:

 /home/runner/work/zenoh-cpp/zenoh-cpp/build/_deps/zenohpico-src/include/zenoh-pico/protocol/definitions/network.h:66:23: error: C++ designated initializers only available with ‘-std=c++20’ or ‘-std=gnu++20’ [-Werror=pedantic]
   66 |     _z_n_qos_t ret = {._val = (uint8_t)((express << 4) | (nodrop << 3) | priority)};

This should be corrected like it was done in this fix:
e76e367

To reproduce the issue build https://github.com/eclipse-zenoh/zenoh-cpp project

The text was updated successfully, but these errors were encountered:

milyin added the bug label

DenisBiryukov91 mentioned this issue

Fix/remove qos designated initializers #354

Merged

milyin closed this as completed in #354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment