Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agents): provide necessary data structures and changes for agent simulation #468

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kschrab
Copy link
Contributor

@kschrab kschrab commented Feb 4, 2025

Description

  • Receive updates from agents generated by the AgentSimulator and process them in Application Ambassador
  • Re-use "RemoveVehicles"-event to remove agent units as well, by renaming it to RemoveUnits.
  • Introduce AgentApplication interface to react on agent updates and leg changes.
  • Refactoring of AgentRoute.PtLeg and PtRoute.PtLeg so that they share a PtTrip object which contains the information about the pt line and stops on the trip, to to avoid duplicated code and object transformation.
  • Visualize agents in WebVisualizer.

Issue(s) related to this PR

  • Partly resolves internal issue 975

Affected parts of the online documentation

Not yet.

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@kschrab kschrab self-assigned this Feb 4, 2025
@kschrab kschrab added the enhancement New feature or request label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant