Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding i686 to detected archs for jubilinux powered edison devices #968

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

crocycroc
Copy link

This is to fix an issue with Intel Edison devices uses Jubilinux for their distribution. The debian based distro is built for i686 specifically and thus shows up with the arch of i686. Adding this into the arch detection statement so that mraa can build.

@tingleby
Copy link
Member

Looks good.

Could you please sign-off your commit as described in:
https://github.com/intel-iot-devkit/mraa/blob/master/CONTRIBUTING.md#code-signing

@crocycroc
Copy link
Author

Signed-off-by: crocycroc [email protected]

@tingleby
Copy link
Member

Since we moved to the Eclipse Foundation, I am going to close and reopen this MR so that the Eclipse checks can trigger

@tingleby tingleby closed this May 14, 2020
@tingleby tingleby reopened this May 14, 2020
@Propanu
Copy link
Contributor

Propanu commented May 14, 2020

IMO, this would look a lot nicer with something like DETECTED_ARCH MATCHES "i[356]86".

@johnwalz97
Copy link

Any update on this???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants