Move login to menu content #1056
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kineticsquid @filiptronicek What do you think? |
|
I'm good with the requirement to make the webui read only. This PR looks good to me. I'd like to hear from @filiptronicek and @spoenemann. |
There was a problem hiding this comment.
Changes look good, the mobile menu improvements are very appreciated.
Makes it possible to make the webui read only as requested in #1041.
Could you point me to the read-only changes in the PR? I couldn't find anything related to it.
|
Hello @amvanbaren, @filiptronicek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to make the webui read only as requested in #1041.
The default menu stays the same. The mobile menu is a bit different.