CMake: Fix DERIVE_ARGUMENT_SHAPE_ARRAY and argument handling #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The re-use of the _PAR prefix means we get aliasing between loki_transform_convert and loki_convert_plan. We fix this by changing the prefix in the outer loki_transform_target.
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/217/index.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
=======================================
Coverage 92.26% 92.26%
=======================================
Files 96 96
Lines 17132 17132
=======================================
Hits 15807 15807
Misses 1325 1325
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
reuterbal
approved these changes
Jan 24, 2024
|
|
||
| if( _PAR_UNPARSED_ARGUMENTS ) | ||
| ecbuild_critical( "Unknown keywords given to loki_transform_target(): \"${_PAR_UNPARSED_ARGUMENTS}\"") | ||
| endif() | ||
|
|
||
| if( NOT _PAR_TARGET ) | ||
| if( NOT _PAR_T_TARGET ) |
There was a problem hiding this comment.
I like the choice _PAR_T. Reads in my head as "party" 🥳
reuterbal
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The re-use of the _PAR prefix means we get aliasing between loki_transform_convert and loki_convert_plan. We fix this by changing the prefix in the outer loki_transform_target.
Please note, this was discussed offline and is exclusively restricted to the CMake layer only, and thus does not come with explicit test coverage. We use this in EC-physics regression, where the use of the
--derive-argument-shape-arrayis needed for performance reasons in the surface sub-branches - it's been verified to work there.