Expression: Remove logical literals in and/or operations during simplify #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation would only resolve .and./.or. operations if all arguments are logical literals. Insterad, we can evaluate `.true. and a` => `.true.` and `.false. and a` => `a`, and vice versa for `or` operations.
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/467/index.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
=======================================
Coverage 93.29% 93.30%
=======================================
Files 221 221
Lines 41360 41362 +2
=======================================
+ Hits 38587 38592 +5
+ Misses 2773 2770 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
reuterbal
approved these changes
Jan 8, 2025
reuterbal
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation would only resolve .and./.or. operations if all arguments are logical literals. Instead, we can evaluate
.true. and a=>.true.and.false. and a=>a, and vice versa fororoperations. This allows us to further trim code paths in dead code elimination where this is used to remove conditionals.