Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoolAllocator: fix handling of first shape/dimension being a range index #482

Open
wants to merge 1 commit into
base: nams-pool-allocator-improvements
Choose a base branch
from

Conversation

MichaelSt98
Copy link
Collaborator

We already handled range indices like e.g., 0:10 properly as long as those aren't the first dimension/shape ...

Thanks @piotrows for pointing this out!

Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/482/index.html

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.17%. Comparing base (e79d1da) to head (b3f8b9f).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           nams-pool-allocator-improvements     #482   +/-   ##
=================================================================
  Coverage                             96.17%   96.17%           
=================================================================
  Files                                   224      224           
  Lines                                 40336    40346   +10     
=================================================================
+ Hits                                  38793    38803   +10     
  Misses                                 1543     1543           
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 96.17% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant