Liquidity Manager #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosfebres
temporarily deployed
to
development
GitHub Actions
Inactive
carlosfebres
temporarily deployed
to
development
GitHub Actions
Inactive
carlosfebres
temporarily deployed
to
development
GitHub Actions
Inactive
StoyanD
had a problem deploying
to
development
GitHub Actions
Failure
StoyanD
requested changes
Dec 18, 2024
Comment on lines
+70
to
+73
| case TokenState.SURPLUS: | ||
| return balance.current - balance.target | ||
| case TokenState.DEFICIT: | ||
| return balance.target - balance.current |
There was a problem hiding this comment.
would Math.abs() work better here?
There was a problem hiding this comment.
Those values are BigInts and Math.abs doesn't support them
There was a problem hiding this comment.
lol, didnt know that, can add a util like
export class Mathb {
static abs(x: bigint): bigint {
return x < 0 ? -x : x;
}
}
...iquidity-manager/services/liquidity-providers/LiFi/providers/evm/custom-evm-step-executor.ts
Outdated
Show resolved
Hide resolved
| import { TokenBalance, TokenConfig } from '@/balance/types' | ||
| import * as LiFi from '@lifi/sdk' | ||
|
|
||
| type TokenState = 'DEFICIT' | 'SURPLUS' | 'IN_RANGE' |
There was a problem hiding this comment.
u define this as an enum src/liquidity-manager/types/token-state.enum.ts
There was a problem hiding this comment.
Yes, enums couldn't be used from type definition files.
There was a problem hiding this comment.
cant you define the type from the enum like so:
type TokenStateType = keyof typeof TokenState
that way you dont duplicate keys and risk forgetting to update both in the future
There was a problem hiding this comment.
I don't think that'd be an issue, if an item in the enum doesn't match the TokenState type TypeScript will return an error.
There was a problem hiding this comment.
yea but y have 2 places where u need to update?
refactoring code and mongo record for new AUDIT protocol
carlosfebres
temporarily deployed
to
development
GitHub Actions
Inactive
carlosfebres
temporarily deployed
to
development
GitHub Actions
Inactive
carlosfebres
temporarily deployed
to
development
GitHub Actions
Inactive
carlosfebres
temporarily deployed
to
development
GitHub Actions
Inactive
StoyanD
reviewed
Jan 2, 2025
src/transaction/smart-wallets/kernel/kernel-account-client-v2.service.ts
Show resolved
Hide resolved
StoyanD
reviewed
Jan 2, 2025
* move bigint conversion * disabling storage prover from being accepted by solver
StoyanD
reviewed
Jan 7, 2025
carlosfebres
temporarily deployed
to
development
GitHub Actions
Inactive
carlosfebres
temporarily deployed
to
development
GitHub Actions
Inactive
* move bigint conversion * disabling storage prover from being accepted by solver * add sameChainFulfill check to validate intent
* move bigint conversion * disabling storage prover from being accepted by solver * updating routes-ts to ~0.2.10-beta update only on patch
* move bigint conversion * moving watch services into own module. adding watch fulfill intent service * creating watch fulfillment event * refactoring watch create intent to use same abstract parent * adding tests for watch fulfillment adding inbox processor adding intent utils method for update - > needs more work and tests * adding default intervals, intentconfigs, and liquiditymanager to config defaults.ts removing eventemitter from app modules adding interval modeule and service adding interval processor and queue adding retry_intent to source intent queue * adding skeleton of retry infeasable * disabling storage prover from being accepted by solver * updating routes-ts to ~0.2.10-beta update only on patch * fixing merge * adding retry infeasable intents tests
StoyanD
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.