Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY up views #547

Open
evantravers opened this issue Aug 8, 2017 · 4 comments
Open

DRY up views #547

evantravers opened this issue Aug 8, 2017 · 4 comments

Comments

@evantravers
Copy link

No description provided.

@evantravers
Copy link
Author

Sorry… new to this Waffle thing. I'm noticing a lot of repetitive code in the views… stuff like the .page-header and so forth. I'm thinking about ripping through and making content_for blocks and partials for all that to simplify the process of making this app a lovely app to use and write. Thoughts?

@rthbound
Copy link
Contributor

rthbound commented Aug 8, 2017

@evantravers: It sounds like a good idea to me. It looks like a few of the .page-header sections include forms -- that could be intentional or not. I'm banking on intentional, so maybe a helper method using content_for blocks and yielding...

<%= page_header(...) do %>
  ... possible form...
<% end %>

@evantravers
Copy link
Author

That's where I'm headed… my qualm is that we may want to hold off front-end refinement until we've got a better sense of design, but I think the few things I want to add won't detract and will make a front-end revamp easier.

@anthonycrumley
Copy link
Contributor

@evantravers That sounds great. The Waffle uses github issues if you like that interaction better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants