New Title System #548
Open
New Title System #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm headed towards simplifying the layout... and I think that the header system is the first piece that could be DRY'd up. To that end, I'm borrowing a great method for cleaning up the page titles from the blog in references, and implementing it in one place to show y'all what it could do. References: - https://coderwall.com/p/a1pj7w/rails-page-titles-with-the-right-amount-of-magic
Trying to DRY up the views
By moving the titles to a i18n file, we increase the ease of translatability and renaming later if we really need it.
evantravers
force-pushed
the
title-system
branch
from
fa8b111 to
11b90f3
Compare
rthbound
requested review from
TadBirmingham
and removed request for
TadBirmingham
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot of repetitive code in the views, this is a first stab at starting
to organize it.
I pulled out the
.page-headerclass, moved it to the application layout. I amusing a
content_forblock to put content in there, though there is more roomfor clean up there.
I also am using the
en.ymli18n file for the titles, which I alsoconsistently upcased.
Relates to #547.