Add theme-color meta to change browser bar color and Fix the gap between collapsible menu and header. #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dodaydream
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I added the theme-color meta to change the colour of the user's browser, providing a more immersive experience.
ref: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name/theme-color
Also I discovered that on desktop, the collapsible menu doesn't positioned correctly, which is caused by scale(1.2) in .m-menu where media: medium. Although this attribute was overwritten by translate3d (0,0,0) which was compiled to translateZ(0px), it doesn't seem to be overwritten correctly.
Therefore I changed the translate3d to unset. And tested on Chrome 120.0.6099.234; Firefox 122.0; Safari 17.1.2, and all worked as expected.