You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version 0.28.8 is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of css-loader.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
css modules are disabled by default, you need setup their use modules option. You can setup their using local (true is alias for this value) and global (previous behaviour) value. Why it is disabled by default? A lot of developers use css without css modules features and they get performance problems due postcss plugins spend time on analyze and processing file.
resolving logic for uls() and import at-rules works the same everywhere, it does not matter whether css modules are enabled (with global and local module) or not. Examples - url('image.png') as require('./image.png'), url('./image.png') as require('./image.png'), url('~module/image.png') as require('module/image.png').
resolving logic for uls() and import at-rules works the same everywhere, it does not matter whether css modules are enabled (with global and local module) or not. Examples - url('image.png') as require('./image.png'), url('./image.png') as require('./image.png'), url('~module/image.png') as require('module/image.png').
by default css modules are disabled (now modules: false disable all css modules features), you can return old behaviour change this on modules: 'global'
css-loader/locals was dropped in favor exportOnlyLocals option
import option only affect on import at-rules and doesn't affect on composes declarations
invalid @import at rules now emit warnings
use postcss@7
Bonus
code refactoring, updating deps and reusing postcss ast increase performance
avoid the "from" argument must be of type string error (#908) (e5dfd23)
invert Function behavior for url and import options (#939) (e9eb5ad)
properly export locals with escaped characters (#917) (a0efcda)
property handle non css characters in localIdentName (#920) (d3a0a3c)
Features
modules options now accepts object config (#937) (1d7a464)
support @value at-rule in selectors (#941) (05a42e2)
BREAKING CHANGES
minimum required nodejs version is 8.9.0
@value at rules now support in selector, recommends checking all @values at-rule usage (hint: you can add prefix to all @value at-rules, for example @value v-foo: black; or @value m-foo: screen and (max-width: 12450px), and then do upgrade)
invert {Function} behavior for url and import options (need return true when you want handle url/@import and return false if not)
exportLocalsStyle option was remove in favor localsConvention option, also it is accept only {String} value (use camelCase value if you previously value was true and asIs if you previously value was false)
exportOnlyLocals option was remove in favor onlyLocals option
modules option now can be {Object} and allow to setup CSS Modules options:
localIdentName option was removed in favor modules.localIdentName option
context option was remove in favor modules.context option
hashPrefix option was removed in favor modules.hashPrefix option
getLocalIdent option was removed in favor modules.getLocalIdent option
localIdentRegExp option was removed in favor modules.localIdentRegExp option
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 0.28.8 of css-loader was just published.
The version 0.28.8 is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of css-loader.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
Release Notes
v0.28.82018-01-05
Bug Fixes
undefined
(#641) (0dccfa9)url()
) (#627) (8897d44)Commits
The new version differs by 10 commits.
0fc46c7
chore(release): 0.28.8
333a2ce
chore(package): update
dependencies
39773aa
ci(travis): use
npm
8897d44
fix: proper URL escaping and wrapping (
url()
) (#627)0dccfa9
fix(loader): correctly check if source map is
undefined
(#641)d999f4a
docs: Update importLoaders documentation (#646)
05c36db
test: removed redundant
modules
argument (#599)c45fa66
test: add case for
url
processing (#603)7039740
docs(README): add anchor tags to options table (#609)
0840c80
Fix markdown for link to webpack resolve.alias doc (#595)
See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴