do not enforce 512² viewport #805
Open
+9
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KTibow
reviewed
Sep 20, 2024
| viewBox="-64 -64 128 128"><path d="m-64 -64H128V128H-64" fill="#fff"/><radialGradient id="a"><stop stop-color="#0bd"/><stop offset="1" stop-color="#17d"/></radialGradient><g stroke="#eee" fill="none"><circle r="52.5" fill="url(#a)" stroke-width="5"/><circle r="45" stroke-dasharray="1.25 8.175" stroke-dashoffset=".5" stroke-width="5.5"/><circle r="42.5" stroke-dasharray="1.25 7.65" stroke-dashoffset="5" stroke-width="10"/></g><path d="M-35 33-6-6 6 6" fill="#eee"/><path d="M35-34-6-6 6 6" fill="#f55"/><path opacity=".3" d="M-35 33l7-5-3 5L6 6l28-35-4 2 4-6"/></svg> |
There was a problem hiding this comment.
shouldn't it be H64V64 or h128v128 instead of H128V128 due to viewbox being width and height, not x2 and y2
|
I need to have a think about this. I see the utility in what you're doing - but I also value the consistency with the other icons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to find a minimal common unit for the drawing to save some bytes and made some proof-of-concept; is it worth trying?