Skip to content

Commit

Permalink
Add isolation2 and parallel-retrieve test matrix entries (apache#801)
Browse files Browse the repository at this point in the history
* Add isolation2 and parallel-retrieve test matrix entries

Adds two test matrix configurations:
- ic-isolation2 for isolation2 installcheck cases
- ic-parallel-retrieve-cursor for isolation2 parallel retrieve cursor tests

Default settings apply:
- num_primary_mirror_pairs: 3
- enable_cgroups: false
- enable_core_check: true
- pg_settings.optimizer: ""

* test: Update expected output for Dynamic Tables integration

Dynamic Tables introduce the `relisdynamic` column to indicate dynamic
table status. This feature enhances lakehouse query performance by
treating external tables more like internal tables, facilitating
faster query execution.

This commit ensures all related tests correctly reflect these changes.

* Move crash specific tests into their own schedule.
  • Loading branch information
edespino authored Dec 20, 2024
1 parent a03c0bf commit ee92070
Show file tree
Hide file tree
Showing 6 changed files with 89 additions and 50 deletions.
3 changes: 3 additions & 0 deletions .asf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ github:
- ic-contrib
- ic-gpcontrib
- ic-fixme
- ic-isolation2
- ic-isolation2-crash
- ic-parallel-retrieve-cursor
- Generate Apache Cloudberry Build Report

# Pull request review requirements
Expand Down
27 changes: 27 additions & 0 deletions .github/workflows/build-cloudberry.yml
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,33 @@ jobs:
pg_settings:
optimizer: ""

- test: ic-isolation2
make_configs:
- src/test/isolation2:installcheck-isolation2
num_primary_mirror_pairs: 3
enable_cgroups: true
enable_core_check: true
pg_settings:
optimizer: ""

- test: ic-isolation2-crash
make_configs:
- src/test/isolation2:installcheck-isolation2-crash
num_primary_mirror_pairs: 3
enable_cgroups: true
enable_core_check: false
pg_settings:
optimizer: ""

- test: ic-parallel-retrieve-cursor
make_configs:
- src/test/isolation2:installcheck-parallel-retrieve-cursor
num_primary_mirror_pairs: 3
enable_cgroups: true
enable_core_check: true
pg_settings:
optimizer: ""

container:
image: apache/incubator-cloudberry:cbdb-build-rocky9-latest
options: >-
Expand Down
8 changes: 7 additions & 1 deletion src/test/isolation2/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@ installcheck-resgroup-v2: install
installcheck-expandshrink: install
$(pg_isolation2_regress_installcheck) --init-file=$(top_builddir)/src/test/regress/init_file --init-file=./init_file_isolation2 --dbname=isolation2expandshrinktest --schedule=$(srcdir)/isolation2_expandshrink_schedule

installcheck-isolation2: install
$(pg_isolation2_regress_installcheck) --init-file=$(top_builddir)/src/test/regress/init_file --init-file=./init_file_isolation2 --schedule=$(srcdir)/isolation2_schedule

installcheck-isolation2-crash: install
$(pg_isolation2_regress_installcheck) --init-file=$(top_builddir)/src/test/regress/init_file --init-file=./init_file_isolation2 --schedule=$(srcdir)/isolation2_crash_schedule

installcheck-parallel-retrieve-cursor: install
$(pg_isolation2_regress_installcheck) $(EXTRA_REGRESS_OPTS) --init-file=$(top_builddir)/src/test/regress/init_file --init-file=./init_file_parallel_retrieve_cursor --bindir='$(bindir)' --inputdir=$(srcdir) --dbname=isolation2parallelretrcursor --load-extension=gp_inject_fault --schedule=$(srcdir)/parallel_retrieve_cursor_schedule

Expand All @@ -83,4 +89,4 @@ installcheck-cbdb-parallel: install
(\
export PGOPTIONS='-c optimizer=off -c enable_parallel=true'; \
$(pg_isolation2_regress_installcheck) --init-file=$(top_builddir)/src/test/regress/init_file --init-file=./init_file_isolation2 --schedule=$(srcdir)/isolation2_schedule \
)
)
17 changes: 17 additions & 0 deletions src/test/isolation2/isolation2_crash_schedule
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Tests for crash recovery
test: uao_crash_compaction_column
test: uao_crash_compaction_row
test: crash_recovery
test: crash_recovery_redundant_dtx
test: crash_recovery_dtm
test: unlogged_heap_tables
test: unlogged_appendonly_tables
test: udf_exception_blocks_panic_scenarios
test: ao_same_trans_truncate_crash
test: frozen_insert_crash

test: prevent_ao_wal

# Tests for packcore, will use the coredumps generated in crash_recovery_dtm,
# so must be scheduled after that one.
test: packcore
18 changes: 0 additions & 18 deletions src/test/isolation2/isolation2_schedule
Original file line number Diff line number Diff line change
Expand Up @@ -14,24 +14,6 @@ test: ao_partition_lock
test: select_dropped_table
test: update_hash_col_utilitymode execute_on_utilitymode

# Tests for crash recovery
test: uao_crash_compaction_column
test: uao_crash_compaction_row
test: crash_recovery
test: crash_recovery_redundant_dtx
test: crash_recovery_dtm
test: unlogged_heap_tables
test: unlogged_appendonly_tables
test: udf_exception_blocks_panic_scenarios
test: ao_same_trans_truncate_crash
test: frozen_insert_crash

test: prevent_ao_wal

# Tests for packcore, will use the coredumps generated in crash_recovery_dtm,
# so must be scheduled after that one.
test: packcore

# Tests on global deadlock detector
test: gdd/prepare
test: gdd/concurrent_update
Expand Down
Loading

0 comments on commit ee92070

Please sign in to comment.