Miniaudio fixes and feature consolidation #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a few lines of effort rolled up in here
All of the optional features exposed to CMakeLists have been collectively rolled up under a single, on by default, EDGE_CLASSIC define. Turning this off will remove the following features from the build:
Fixed CTDs when switching music tracks with Miniaudio due to unnecessary allocation/deletion of various playback/decoder objects (they can simply be uninitialized and reassigned if needed)
Consolidated MIDI and IMF music decoders into the same source file, since they both use the same MIDI sequencer