Skip to content

Commit

Permalink
[Bug] SONiC Extension Packages Migration Error During New SONiC Image…
Browse files Browse the repository at this point in the history
… Install

* In 17/05/2023, SONiC updates the format of CLI section in the manifest.json.
* The implementation was updated in 202311 or later branches.
* However, the PR #2753 reported there is a error occur when the CLI migration.
* The root cause is occurred while a CLI field (show/config/clear) is empty ('').
* This PR modifies the parser of the cli_plugins field in the manifest.py.
  • Loading branch information
PeterTSW-EC authored and CharlieChenEC committed Jul 17, 2024
1 parent 22ca1a3 commit 3e46c54
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sonic_package_manager/manifest.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def marshal(self, value):
raise ManifestError(f'{value} has items not of type {self.type.__name__}')
return value
elif isinstance(value, self.type):
return [value]
return [] if not value else [value]
else:
raise ManifestError(f'{value} is not of type {self.type.__name__}')

Expand Down

0 comments on commit 3e46c54

Please sign in to comment.