-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k8s: add 1.29, remove 1.26, default 1.28 #2803
Conversation
✅ Deploy Preview for constellation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM, did we check the kubeadm admin-conf change? Didn't look into it in too much detail, but this sounds like something that might trickle down to our kubeadm usage?
Yes. I tested this and also looked this up in our code: we generate the constellation-admin.conf based on a separately created x509 key, that will still be part of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. should we cover an upgrade test from 1.28 to 1.29?
Will do! EDIT: the pipeline cannot test this automatically, since it needs to first upgrade from 1.27 to 1.28 and then from 1.28 to 1.29. |
Context
Add support for k8s 1.29 and move versions accordingly.
Proposed change(s)
Additional info
Checklist