Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s: add 1.29, remove 1.26, default 1.28 #2803

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Jan 8, 2024

Context

Add support for k8s 1.29 and move versions accordingly.

Proposed change(s)

  • k8s: add 1.29, remove 1.26, default 1.28

Additional info

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit 8906f56
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/659bda283463650008695445
😎 Deploy Preview https://deploy-preview-2803--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Coverage report

Package Old New Trend
internal/versions 9.70% 9.70% 🚧

@malt3 malt3 added the dependencies Pull requests that update a dependency file label Jan 8, 2024
@malt3 malt3 added this to the v2.15.0 milestone Jan 8, 2024
@malt3 malt3 marked this pull request as ready for review January 8, 2024 12:03
Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, did we check the kubeadm admin-conf change? Didn't look into it in too much detail, but this sounds like something that might trickle down to our kubeadm usage?

@malt3
Copy link
Contributor Author

malt3 commented Jan 8, 2024

[...] did we check the kubeadm admin-conf change?

Yes. I tested this and also looked this up in our code: we generate the constellation-admin.conf based on a separately created x509 key, that will still be part of the system:masters group.

Copy link
Contributor

@elchead elchead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. should we cover an upgrade test from 1.28 to 1.29?

@malt3
Copy link
Contributor Author

malt3 commented Jan 8, 2024

should we cover an upgrade test from 1.28 to 1.29?

Will do!

EDIT: the pipeline cannot test this automatically, since it needs to first upgrade from 1.27 to 1.28 and then from 1.28 to 1.29.
I tested this manually instead.

@malt3 malt3 merged commit a8bca88 into main Jan 8, 2024
48 of 50 checks passed
@malt3 malt3 deleted the deps/kubernetes/1-29 branch January 8, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants