docs: how to reproduce released artifacts #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
burgerdev
changed the title
burgerdev
requested review from
m1ghtym0,
3u13r,
elchead,
msanft and
daniel-weisse
msanft
approved these changes
Oct 22, 2024
| uses: ./.github/actions/setup_bazel_nix | ||
| if: matrix.deps == 'conventional' | ||
|
|
||
| - name: Setup Bazel (eccentric) |
There was a problem hiding this comment.
I wonder if I should perform the nix installation manually, too, to serve as build environment setup instructions.
There was a problem hiding this comment.
Removed the action and added a manual download/exec of the nix-installer. Renovate should upgrade it every once in a while with the config change.
3u13r
reviewed
Oct 22, 2024
elchead
approved these changes
Oct 22, 2024
daniel-weisse
approved these changes
Oct 23, 2024
thomasten
reviewed
Oct 24, 2024
Co-authored-by: Daniel Weiße <[email protected]> Co-authored-by: Thomas Tendyck <[email protected]>
burgerdev
force-pushed
the
burgerdev/reproducibility
branch
from
20d81f4 to
0c7fbf7
Compare
thomasten
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There's an implicit assumption that our release artifacts are reproducible, but the exact requirements are unclear. According to reproducible-builds.org, a reproducible build needs to come with a build environment definition.
A user found an issue where the local Nix store state influences build outcomes. This was not caught by our tests because they are only testing a narrow build environment.
Proposed change(s)
Additional info
Checklist
--hard-deference