Allow adding additional IPs for Coordinator root cert #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Weiße <[email protected]>
✅ Deploy Preview for marblerun-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thomasten
reviewed
Nov 18, 2023
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
thomasten
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
EDG_COORDINATOR_DNS_NAMESenv variableAdditional info
Previously, IP addresses were incorrectly added as additional DNS names of the certificate. This means any generated Certificate was only signed for the IP adresses
127.0.0.1and the ipv6 equivalent. This effectively made it required to provide a DNS name when exposing the client API publicly, e.g. when running the Coordinator in Kubernetes and using a Loadbalancer to assign a public IP to the client API.