Fix get_acrossword_left #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @edma2 thanks for sharing this package. I'm one of the creators of http://literakiapp.com (it's a word game similar to scrabble but for Polish dictionary). I'm in the process of writing a computer player based on Jacobson and Appel paper in node.js and I ran into your repo which is very helpful.
While testing it I noticed this little bug. If I understand correctly we should be moving left and grabbing the entire word (prefix) from the left. Is that correct? I know you wrote this 7 years ago so it's probably hard to remember ;)