Skip to content

Commit

Permalink
chore(dev): GitHub Actions step/job graceful fail (necessary for Wind…
Browse files Browse the repository at this point in the history
…ows but not Linux/Mac?)
  • Loading branch information
danielweck committed Dec 10, 2024
1 parent a48e768 commit e1828d1
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,11 @@ jobs:
env:
RELEASE_TAG: ${{ matrix.release_tag }}
steps:
# should fail gracefully on Windows (CMD only, because PowerShell "||" fails)
# graceful fail?
- run: |-
pwdx || echo OK || true
shell: cmd
continue-on-error: true
- name: Microsoft Windows dumpbin to PATH
if: startsWith(matrix.osarch, 'windows-')
run: >
Expand Down Expand Up @@ -174,6 +175,7 @@ jobs:
run: >
(dumpbin /headers "node_modules\electron\dist\electron.exe" | findstr /i machine) && (node_modules\\electron\\dist\\electron.exe --no-sandbox --version || echo INVALID_ARCH || true) && (node_modules\\electron\\dist\\electron.exe --no-sandbox --abi || echo INVALID_ARCH || true)
shell: cmd
continue-on-error: true
- name: Electron version + arch (Linux)
#if: ${{ matrix.osarch == 'linux-intel' || matrix.osarch == 'linux-arm' }}
if: startsWith(matrix.osarch, 'linux-')
Expand Down

0 comments on commit e1828d1

Please sign in to comment.