Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

[2023.10.2] Release #115

Merged
merged 3 commits into from
Oct 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"

[tool.poetry]
name = "problem-sets"
version = "2023.10.1"
version = "2023.10.2"
description = "Challenges and solutions for the Python training course"
license = "MIT"
authors = [
Expand Down
16 changes: 4 additions & 12 deletions src/calc/func.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,8 @@ def get_sum_of_strings(number_1: str, number_2: str, /) -> str:
"""

# remove leading zeros
for digit in number_1:
if digit != "0":
break
number_1 = number_1[1::]
for digit in number_2:
if digit != "0":
break
number_2 = number_2[1::]
number_1 = number_1.lstrip("0")
number_2 = number_2.lstrip("0")

if not number_1 or not number_2:
return number_1 or number_2 or "0"
Expand All @@ -162,10 +156,8 @@ def get_sum_of_strings(number_1: str, number_2: str, /) -> str:
number_1, number_2 = number_1[::-1], number_2[::-1]

# make strings of the same lengths
while len(number_1) < size:
number_1 += "0"
while len(number_2) < size:
number_2 += "0"
number_1 += "0" * (size - len(number_1))
number_2 += "0" * (size - len(number_2))

carry: int = 0
for digit_1, digit_2 in zip(number_1, number_2):
Expand Down
1 change: 1 addition & 0 deletions tests/datasets/filters_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ def test_dataset_filter_no_keys(dataset):
{"x": 1, "y": 1}, {"x": 1, "y": 2}, {"x": 2, "y": 1}, {"x": 2, "y": 2},
]
assert filters.filter_by_values(dataset) == test_dataset
assert filters.filter_by_values(dataset, []) == test_dataset


def test_empty_dataset():
Expand Down