This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
[Solved] Check vowels #93 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have changed the base branch to |
shorodilov
reviewed
Nov 24, 2023
There was a problem hiding this comment.
Looks good to me, nice work @Rishitha-VasiReddy.
I need to check the reason the tests are failed, and we can merge it once its fixed.
shorodilov
suggested changes
Nov 24, 2023
There was a problem hiding this comment.
Found the reason the tests are failed.
Just fix imports in test_vowels, and we will be ready to merge changes into devel.
Nice work, thanks @Rishitha-VasiReddy.
Closed
Co-authored-by: Serhii Horodilov <[email protected]>
|
I've made the necessary changes. Please review |
Added docstrings
|
Nice. Need to check the reason tests are failed. |
shorodilov
approved these changes
Nov 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a PR for this issue. Please review