Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

Conversation

pratyusha-samidhapudi
Copy link
Contributor

Created PR to issue referencing #69

@shorodilov shorodilov changed the base branch from master to devel November 24, 2023 11:39
@shorodilov
Copy link
Member

shorodilov commented Nov 24, 2023

I have changed the base branch to devel.
We are following GitFlow approach within this project.
master branch contains released features only, and the devel is used to accumulate changes while development.

UPD: BTW, this is the reason it's better to start new feature branches from devel.

@shorodilov shorodilov self-requested a review November 24, 2023 11:42
Copy link
Member

@shorodilov shorodilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work @Rishitha-VasiReddy.

I need to check the reason the tests are failed, and we can merge it once its fixed.

src/FindSquare/square.py Show resolved Hide resolved
Copy link
Member

@shorodilov shorodilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find the reason the tests are failed.
It's all about imports in test_square module.
Fix it please, and we will be ready to merge changes into devel.

Nice work, thanks @pratyusha-samidhapudi

src/FindSquare/square.py Show resolved Hide resolved
@shorodilov shorodilov linked an issue Nov 24, 2023 that may be closed by this pull request
@shorodilov shorodilov self-requested a review November 25, 2023 14:49
@pratyusha-samidhapudi
Copy link
Contributor Author

Hey @shorodilov, I have changed the import statement accordingly. Can you please let me know what other changes I need to make? Thanks in advance!

@shorodilov
Copy link
Member

Hey @shorodilov, I have changed the import statement accordingly. Can you please let me know what other changes I need to make? Thanks in advance!

Thanks a lot for your work.

It seems tests are keeping fail.
I will review this tomorrow morning (EEST) and come back here asap.

Copy link
Member

@shorodilov shorodilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all fine.
The reason "tox runner" fails with testing - FindSquare package is not included to the list of packages to install.
It's not a big deal, since I will re-structure code base on pre-release stage.
Good job.

LTGM.

image
image

@shorodilov shorodilov merged commit 457b071 into edu-python-course:devel Nov 27, 2023
2 of 12 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find square
2 participants