Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to statistics in profile #17

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

Edmondi-Kacaj
Copy link
Contributor

Hello @torsten-simon

For easily getting around and create a feeling of one smooth world users want directly by clicking on things be able to go there.

goal: from the profile page user can by clicking directly go to their workspace or the collections page (what user currently can, only by the top left menu)

So I have created a branch and add links to user-login profile statistics, so each user that has access to the workspace (if the workspace is not disabled by the administrator) and is login (work only for the user that accesses his/her own profile) can go to own workspace or own collection by clicking the links that now are activated to statistics (material, collection)

Now user can access directly workspace or Collection, from profile,
@Edmondi-Kacaj
Copy link
Contributor Author

Hello @torsten-simon,

when you have time can you please see this pull request.

@torsten-simon
Copy link
Member

Hi @Edmondi-Kacaj ,
thanks for the contribution!

As of now we can't see much of an use-case or advantage by simply linking to the plain workspace. I would personally think that it would make much more sense to directly see the materials counted their. The plain workspace does not necessarially do that.

Can you may explain a bit more the intention behind this linking feature? I think in order to include it into the base system we would need to give a benefit and more streamlined experience (e.g. directly showing the list of your published cc materials etc.).

@Edmondi-Kacaj
Copy link
Contributor Author

Hello @torsten-simon

The idea was that, when the user is in profile, he can access the workspace, collection without open, left panel.
this was the first idea, but of course, we implement, that links that have CC-Materials (send to search and filter all your public materials), did I get right that you want only button CC-Materials==> to send to public material each user have, if they have of course.

@Edmondi-Kacaj
Copy link
Contributor Author

Hello @torsten-simon
I have made some changes in this pull request like I have made it configurable so everyone can choose if he/she wants to activate or deactivated links in profile, and also the URL now is better

can you have a look ?

thanks
Edmond

/**
* This function will build query and navigate to specific Profile links
*/
public navigateTo(component: string): void {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use type-safe parameters (enum or defined string list)

<div class="stat">
{{'PROFILES.STATS.MATERIALS' | translate}}
</div>
<div class="value">
{{ userStats.nodeCount }}
</div>
</div>
<div>
<div [class.stat-link]="canActivateLinks()"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to use "routerLink" if possible, since this will support default browser behaviour for links and improves accessibillity

@Edmondi-Kacaj
Copy link
Contributor Author

Hello @torsten-simon

I hope is OK now, can you have a look.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants