Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For the CC licenses url with country versions #30

Open
wants to merge 10 commits into
base: maven/develop
Choose a base branch
from

Conversation

Edmondi-Kacaj
Copy link
Contributor

Hello @torsten-simon

For the CC licenses with country versions, there is currently an incorrect link displayed on the details pages in Edu-Sharing. There it refers to the "unported" version instead of the country-specific version.

Example: https://www.twillo.de/edu-sharing/components/render/1d1feb01-c412-4c5a-803d-7b90376418ea

  1. uses CC-BY-SA 3.0 Germany
  2. but the displayed link is https://creativecommons.org/licenses/by-sa/3.0/deed.mds instead of https://creativecommons.org/licenses/by-sa/3.0/de/deed.mds

Kind regards
Edmond

@Edmondi-Kacaj
Copy link
Contributor Author

Hello @torsten-simon

What about this pull request, is possible to merge and be ready in the next minor/major update of edu-sharing,

@Edmondi-Kacaj
Copy link
Contributor Author

Hello @torsten-simon

What about this pull request, is possible to merge and be ready in the next minor/major update of edu-sharing,

@torsten-simon
Copy link
Member

It doesn't work and provides wrong result, i.e. a CC-BY licensed element generates this URL in the Metadata Template:
https://creativecommons.org/licenses/by/4.0//deed.mds

Neither the language nor the jurisdiction is provided with a valid value.

@Edmondi-Kacaj Edmondi-Kacaj marked this pull request as draft November 9, 2022 08:13
@Edmondi-Kacaj Edmondi-Kacaj marked this pull request as ready for review November 16, 2022 15:54
@Edmondi-Kacaj
Copy link
Contributor Author

Hello @torsten-simon

can you have a look?

@torsten-simon torsten-simon changed the base branch from develop to maven/develop November 2, 2023 15:28
@Edmondi-Kacaj Edmondi-Kacaj marked this pull request as draft April 16, 2024 06:49
@Edmondi-Kacaj Edmondi-Kacaj marked this pull request as ready for review April 16, 2024 12:47
@Edmondi-Kacaj
Copy link
Contributor Author

Hello @torsten-simon ,

I've resolved all the conflicts in the merge request, and I believe it's now ready for your review.

Could you please take a look and provide your feedback? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants